Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tune] Allow more versatile experiment analysis loading #20181

Merged
merged 3 commits into from
Nov 10, 2021
Merged

[tune] Allow more versatile experiment analysis loading #20181

merged 3 commits into from
Nov 10, 2021

Conversation

krfricke
Copy link
Contributor

@krfricke krfricke commented Nov 9, 2021 •
edited
Loading

Why are these changes needed?

Collecting some initial feedback for better experiment analysis loading.

Related issue number

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@krfricke krfricke requested a review from Yard1 November 9, 2021 13:14
@krfricke krfricke marked this pull request as ready for review November 9, 2021 17:22
Yard1
Yard1 approved these changes Nov 9, 2021
View reviewed changes
Copy link
Member

@Yard1 Yard1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

python/ray/tune/trial.py Show resolved Hide resolved
@Yard1 Yard1 mentioned this pull request Nov 9, 2021
Merged
6 tasks
@krfricke
Copy link
Contributor Author

Thanks, added a comment, tests passed before, so will merge after lint passed

@krfricke krfricke merged commit 4e3e213 into ray-project:master Nov 10, 2021
@krfricke krfricke deleted the tune/exp-analysis branch November 10, 2021 11:46
@krfricke krfricke mentioned this pull request Apr 26, 2022
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yard1 Yard1 Yard1 approved these changes

Assignees

@Yard1 Yard1

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@krfricke @Yard1